On 20/01/2023 15:09, Yann Sionneau wrote: > From: Jules Maselbas <jmaselbas@xxxxxxxxx> > > Add documentation for `kalray,kv3-1-pwr-ctrl` binding. > > Co-developed-by: Jules Maselbas <jmaselbas@xxxxxxxxx> > Signed-off-by: Jules Maselbas <jmaselbas@xxxxxxxxx> > Signed-off-by: Yann Sionneau <ysionneau@xxxxxxxxx> > --- > > Notes: > V1 -> V2: new patch > > .../kalray/kalray,kv3-1-pwr-ctrl.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > create mode 100644 Documentation/devicetree/bindings/kalray/kalray,kv3-1-pwr-ctrl.yaml All the usual comments plus - wrong directory. Power controllers go to respective power directory. > > diff --git a/Documentation/devicetree/bindings/kalray/kalray,kv3-1-pwr-ctrl.yaml b/Documentation/devicetree/bindings/kalray/kalray,kv3-1-pwr-ctrl.yaml > new file mode 100644 > index 000000000000..968674bb0c63 > --- /dev/null > +++ b/Documentation/devicetree/bindings/kalray/kalray,kv3-1-pwr-ctrl.yaml > @@ -0,0 +1,29 @@ > +# SPDX-License-Identifier: GPL-2.0 > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/kalray/kalray,kv3-1-pwr-ctrl# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Kalray cluster Power Controller (pwr-ctrl) > + > +description: | > + The Power Controller (pwr-ctrl) control cores reset and wake-up procedure. > + > +properties: > + compatible: > + const: kalray,kv3-1-pwr-ctrl > + reg: > + maxItems: 1 > + > +required: > + - compatible > + - reg > + > +examples: > + - | > + pwr_ctrl: power-controller@a40000 { > + compatible = "kalray,kv3-1-pwr-ctrl"; > + reg = <0x00 0xa40000 0x00 0x4158>; I really doubt that you tested it... Examples are not run with address cells 2. Best regards, Krzysztof
