On 1/17/23 16:16, Reinette Chatre wrote: > Hi Babu, > > On 1/13/2023 7:20 AM, Babu Moger wrote: >> New AMD processors can now support following QoS features. >> >> 1. Slow Memory Bandwidth Allocation (SMBA) >> With this feature, the QOS enforcement policies can be applied >> to the external slow memory connected to the host. QOS enforcement >> is accomplished by assigning a Class Of Service (COS) to a processor >> and specifying allocations or limits for that COS for each resource >> to be allocated. >> >> Currently, CXL.memory is the only supported "slow" memory device. With >> the support of SMBA feature the hardware enables bandwidth allocation >> on the slow memory devices. >> >> 2. Bandwidth Monitoring Event Configuration (BMEC) >> The bandwidth monitoring events mbm_total_event and mbm_local_event >> are set to count all the total and local reads/writes respectively. >> With the introduction of slow memory, the two counters are not enough >> to count all the different types are memory events. With the feature >> BMEC, the users have the option to configure mbm_total_event and >> mbm_local_event to count the specific type of events. >> >> Following are the bitmaps of events supported. >> Bits Description >> 6 Dirty Victims from the QOS domain to all types of memory >> 5 Reads to slow memory in the non-local NUMA domain >> 4 Reads to slow memory in the local NUMA domain >> 3 Non-temporal writes to non-local NUMA domain >> 2 Non-temporal writes to local NUMA domain >> 1 Reads to memory in the non-local NUMA domain >> 0 Reads to memory in the local NUMA domain >> >> This series adds support for these features. Also added a minor cleanup(PATCH 1). >> >> Feature description is available in the specification, "AMD64 Technology Platform Quality of Service Extensions, Revision: 1.03 Publication # 56375 >> Revision: 1.03 Issue Date: February 2022". >> >> Link: https://bugzilla.kernel.org/show_bug.cgi?id=206537 >> Link: https://www.amd.com/en/support/tech-docs/amd64-technology-platform-quality-service-extensions > This series looks good to me. I added my "Reviewed-by" tag to patch 13/13. All > the other patches in this series already have my "Reviewed-by" tag. Thank you very much. Babu Moger
