On 2022/12/9, 3:48 PM, "Krzysztof Kozlowski" <krzysztof.kozlowski@xxxxxxxxxx <mailto:krzysztof.kozlowski@xxxxxxxxxx>> wrote: On 09/12/2022 01:54, Billy Tsai wrote: > > > > However I am surprised to see such change, so I have no clue why this > > > > was done. > > > > > Actually now I see it was like that in previous patch, I just missed it > > > during previous review. Anyway this must be fixed. > > > > I have two module (PWM and TACH) but share with the same base address, > > The PWM will use the offset (N*0x10) + 0x0 and 0x04. > > The TACH will use the offset (N*0x10) + 0x8 and 0x0c. > > The range of the N is 0~15. > > Can you give me some advice to fix this problem without using simple-mfd? > Use regular driver which populates children. I think that my scenario meets the definition in mfd.txt: - A range of memory registers containing "miscellaneous system registers" also known as a system controller "syscon" or any other memory range containing a mix of unrelated hardware devices. Can you tell me the considerations for not using simple-mfd? Thanks Best Regards, Billy Tsai
