Hi Babu, On 12/22/2022 3:31 PM, Babu Moger wrote: ... > +static ssize_t mbm_total_bytes_config_write(struct kernfs_open_file *of, > + char *buf, size_t nbytes, > + loff_t off) > +{ > + struct rdt_resource *r = of->kn->parent->priv; > + int ret; > + > + /* Valid input requires a trailing newline */ > + if (nbytes == 0 || buf[nbytes - 1] != '\n') > + return -EINVAL; > + > + cpus_read_lock(); Could you please elaborate why this lock is needed here as well as in the following patch? Reinette