Miguel Ojeda <miguel.ojeda.sandonis@xxxxxxxxx> writes: >> - It did a bunch of other building, starting with objtool - again, never >> needed for the docs build before. > > Yeah, rustdoc, like the compiler, requires dependencies to be > available to understand the code. Thus some things need to be > compiled, like for the normal build. Does it really need objtool? A certain amount of extra building is OK as long as it doesn't radically slow down the (already glacial) docs build. I'd like it to not *break* the docs build if the right dependencies aren't there, though. >> version is really supported, but it would be nice to fail a bit more >> gracefully if at all possible. > > Do you mean failing in the `scripts/rust_is_available.sh` step instead > of warning? We could also add versioning information to that script, > so that it knows more about which versions work etc., but I guess at > that point it would be best to simply start supporting several > versions, which may be a bit too early to split CI runs on that since > it would require some degree of testing. It seems like that step should fail regardless, not just for the docs build, no? Otherwise, though, it would suffice to turn a failure to build the Rust docs into a warning-level event for the docs build; I'm mostly concerned about it breaking the build as a whole. Supporting multiple Rust versions would be nice, but it's up to you to decide when you think you can do that; I don't think the docs build should drive it. Thanks, jon
