On Fri 16-12-22 10:18:20, Andrew Morton wrote: > On Fri, 16 Dec 2022 10:54:16 +0100 Michal Hocko <mhocko@xxxxxxxx> wrote: > > > I have noticed that the patch made it into Linus tree already. Can we > > please revert it because the semantic is not really clear and we should > > really not create yet another user API maintenance problem. > > Well dang. I was waiting for the discussion to converge, blissfully > unaware that the thing was sitting in mm-stable :( I guess the > > Acked-by: Michal Hocko <mhocko@xxxxxxxx> > Acked-by: Shakeel Butt <shakeelb@xxxxxxxxxx> > Acked-by: Muchun Song <songmuchun@xxxxxxxxxxxxx> > > fooled me. Hmm, as pointed out in http://lkml.kernel.org/r/Y5bsmpCyeryu3Zz1@xxxxxxxxxxxxxx I've failed to see through all the consequences of the implementation. SO my bad here to add my ack before fully understanding all the implications. > I think it's a bit premature to revert at this stage. Possibly we can > get to the desired end state by modifying the existing code. Possibly > we can get to the desired end state by reverting this and by adding > something new. Sure if we can converge to a proper implementation during the rc phase then it would be ok. I cannot speak for others but at least for me upcoming 2 weeks would be mostly offline so I cannot really contribute much. A revert would be much more easier from the coordination POV IMHO. Also I do not think there is any strong reason to rush this in. I do not really see any major problems to have this extension in 6.2 -- Michal Hocko SUSE Labs
