On 10.07.2013, at 16:17, Alexey Kardashevskiy wrote: > On 07/10/2013 08:27 PM, Alexander Graf wrote: >> >> On 10.07.2013, at 01:35, Alexey Kardashevskiy wrote: >> >>> On 07/10/2013 01:35 AM, Alexander Graf wrote: >>>> On 06/27/2013 07:02 AM, Alexey Kardashevskiy wrote: >>>>> Signed-off-by: Alexey Kardashevskiy<aik@xxxxxxxxx> >>>>> --- >>>>> include/uapi/linux/kvm.h | 2 ++ >>>>> 1 file changed, 2 insertions(+) >>>>> >>>>> diff --git a/include/uapi/linux/kvm.h b/include/uapi/linux/kvm.h >>>>> index 970b1f5..0865c01 100644 >>>>> --- a/include/uapi/linux/kvm.h >>>>> +++ b/include/uapi/linux/kvm.h >>>>> @@ -667,6 +667,7 @@ struct kvm_ppc_smmu_info { >>>>> #define KVM_CAP_PPC_RTAS 91 >>>>> #define KVM_CAP_IRQ_XICS 92 >>>>> #define KVM_CAP_SPAPR_MULTITCE 93 >>>>> +#define KVM_CAP_SPAPR_TCE_IOMMU 94 >>>>> >>>>> #ifdef KVM_CAP_IRQ_ROUTING >>>>> >>>>> @@ -923,6 +924,7 @@ struct kvm_s390_ucas_mapping { >>>>> /* Available with KVM_CAP_PPC_ALLOC_HTAB */ >>>>> #define KVM_PPC_ALLOCATE_HTAB _IOWR(KVMIO, 0xa7, __u32) >>>>> #define KVM_CREATE_SPAPR_TCE _IOW(KVMIO, 0xa8, struct >>>>> kvm_create_spapr_tce) >>>>> +#define KVM_CREATE_SPAPR_TCE_IOMMU _IOW(KVMIO, 0xaf, struct >>>>> kvm_create_spapr_tce_iommu) >>>> >>>> Please order them by number. >>> >>> Oh. Again :( We have had this discussion with Scott Wood here already. >>> Where _exactly_ do you want me to put it? >> >> 8 lines further down. With a comment saying when it's available. Also why is it af, not ad? > > > 0xad and 0xae are taken. > Where should I have commented this? In the commit message? Or in the patch > itself? Yeah, with a comment right in between 0xad and your 0xaf entry explaining the gap. Alex > > >>> Many sections, not really ordered. Thank you. >> >> They should all be ordered inside of their own categories. > > > -- > Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html