On Wed, Dec 14, 2022 at 01:57:14PM -0500, Theodore Ts'o wrote: > + * The number of upstream kernel contributions by engineer, team, and > + organization (e.g., all people reporting up to a manager, director, > + or VP). This is the only one that gave me pause. Seems eminently gameable by trash variable-name-tweaking patches, unnecessary commit splitting etc. I'm not going to name names but I'm seeing some of this as it is. And if people decide to count patches posted as opposed to commits, oh my ... I don't think we should make people focus on the number of contributions as opposed to their quality, and incorrect incentives tend to promote incorrect behaviour. Fundamentally I presume companies will evaluate contributions based on how important the given functionality is for the company, so I'm not sure we need to get involved here. Maybe just add this at the end: + The metrics can be measured by team or + organization (e.g., all people reporting up to a manager, director, + or VP). Or simply drop this part. Besides this: Acked-by: Michael S. Tsirkin <mst@xxxxxxxxxx> -- MST
