On Mon, Jun 03, 2013 at 03:18:51PM +0100, Lee Jones wrote: > On Mon, 03 Jun 2013, J Keerthy wrote: > > + optional chip specific regulator fields :- > > + ti,warm-reset - maintain voltage during warm reset(boolean) > Pushing the boat out a bit here, but is it possible to reuse > 'regulator-always-on' for this? This sounds more like "don't reset over reboot" than "never change the enable state". > > + ti,roof-floor - control voltage selection by pin(boolean) > Is this the same as a GPIO regulator? > If so, you might not need to add superfluous vendor specific properties. Lots of regulators have the ability to do things like switch between programmable voltages based on GPIOs (enabling a fast change to a known voltage) - the roof-floor naming sounds like this. Usually there's also register based element for selecting the voltage. > See: Documentation/devicetree/bindings/regulator/gpio-regulator.txt > > + ti,sleep-mode - mode to adopt in pmic sleep 0 - off, 1 - auto, > > + 2 - eco, 3 - forced pwm > I've seen lots of sleep-mode properties, can't we define a generic > one? We should make some of this more standard (at least things like voltages) but the whole concept of what sleep mode is is at best fuzzy. You typically need different selections for suspend to RAM and suspend to disk, plus often the suspend configuration is dynamic depending on what the system is doing since suspend is just CPU suspend not system suspend and there's also some changes that might happen depending on which wake sources are currently available.
Attachment:
signature.asc
Description: Digital signature
