On Fri, Dec 9, 2022 at 3:30 AM Roberto Sassu <roberto.sassu@xxxxxxxxxxxxxxx> wrote: > > From: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > > Align with the description of fs_context_parse_param in lsm_hooks.h, which > seems the right one according to the code. > > Signed-off-by: Roberto Sassu <roberto.sassu@xxxxxxxxxx> > --- > Documentation/filesystems/mount_api.rst | 9 ++++----- > 1 file changed, 4 insertions(+), 5 deletions(-) I'm going to leave this patch as a "hold" for right now. The existing text is arguably not great, but I'm not really in love with the replacement text taken from the LSM hook comments; given the merge window opens in a couple of days, we don't have much time to fiddle with the wording so let's just hold this for a little bit. These comment corrections (which are very welcome!) have also reminded me that we really should move the hook comment blocks out of the header file and into security.c like every other kernel function. This should help increase their discoverability while also making it easier to maintain the comments over time. I'm going to post a first pass at this as soon as the merge window closes, and once that is done we can do further work to cleanup the descriptions and add more detail (including notes both for the other kernel subsystems that call the hooks and the LSM devs who provide implementations). -- paul-moore.com
