On Mon, Dec 05, 2022 at 04:46:31AM +0000, Veerasenareddy Burru wrote: > > > > -----Original Message----- > > From: Leon Romanovsky <leon@xxxxxxxxxx> > > Sent: Thursday, December 1, 2022 12:11 AM > > To: Veerasenareddy Burru <vburru@xxxxxxxxxxx> > > Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Liron Himi > > <lironh@xxxxxxxxxxx>; Abhijit Ayarekar <aayarekar@xxxxxxxxxxx>; Sathesh > > B Edara <sedara@xxxxxxxxxxx>; Satananda Burla <sburla@xxxxxxxxxxx>; > > linux-doc@xxxxxxxxxxxxxxx; David S. Miller <davem@xxxxxxxxxxxxx>; Eric > > Dumazet <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; > > Paolo Abeni <pabeni@xxxxxxxxxx> > > Subject: Re: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for control > > messages > > > > On Wed, Nov 30, 2022 at 03:44:30PM +0000, Veerasenareddy Burru wrote: > > > > > > > > > > -----Original Message----- > > > > From: Leon Romanovsky <leon@xxxxxxxxxx> > > > > Sent: Wednesday, November 30, 2022 1:30 AM > > > > To: Veerasenareddy Burru <vburru@xxxxxxxxxxx> > > > > Cc: netdev@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; Liron Himi > > > > <lironh@xxxxxxxxxxx>; Abhijit Ayarekar <aayarekar@xxxxxxxxxxx>; > > > > Sathesh B Edara <sedara@xxxxxxxxxxx>; Satananda Burla > > > > <sburla@xxxxxxxxxxx>; linux-doc@xxxxxxxxxxxxxxx; David S. Miller > > > > <davem@xxxxxxxxxxxxx>; Eric Dumazet <edumazet@xxxxxxxxxx>; > > Jakub > > > > Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni <pabeni@xxxxxxxxxx> > > > > Subject: [EXT] Re: [PATCH net-next v2 2/9] octeon_ep: poll for > > > > control messages > > > > > > > > External Email > > > > > > > > -------------------------------------------------------------------- > > > > -- On Tue, Nov 29, 2022 at 05:09:25AM -0800, Veerasenareddy Burru > > > > wrote: > > > > > Poll for control messages until interrupts are enabled. > > > > > All the interrupts are enabled in ndo_open(). > > > > > > > > So what are you saying if I have your device and didn't enable > > > > network device, you will poll forever? > > > Yes, Leon. It will poll periodically until network interface is enabled. > > > > I don't know if it is acceptable behaviour in netdev, but it doesn't sound right > > to me. What type of control messages will be sent by FW, which PF should > > listen to them? > > > > These messages include periodic keep alive (heartbeat) messages from FW and control messages from VFs. > Every PF will be listening for its own control messages. @netdev, as I said, I don't know if it is valid behaviour in netdev. Can you please comment? Thanks
