> > + writeb(val, drvdata->base + channel); > The mixed use of direct writes and regmap is odd and confusing. > Why use regmap for plreg_map and for fn2_map but not for base ? > Can this be unified ? If not, why ? I will still require three separate areas to access these registers as they are spaced far apart (> 0x20000000). I will create a comment to explain this. As for being unified methods I believe they can be all __iomem's or regmaps. Thanks, -Nick Hawkins
