Re: [PATCH v2 2/2] earlycon: Let users set the clock frequency

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On 24. 11. 22, 11:02, Ricardo Ribalda wrote:
...
--- a/drivers/tty/serial/earlycon.c
+++ b/drivers/tty/serial/earlycon.c
@@ -120,9 +120,15 @@ static int __init parse_options(struct earlycon_device *device, char *options)
  	}
if (options) {
+		char *uartclk;
+
  		if (kstrtouint(options, 0, &device->baud) < 0)
  			pr_warn("[%s] unsupported earlycon baud rate option\n",
  				options);

IMO this won't work if there is a comma in options (i.e. your new clkrate param). kstrtouint will return -EINVAL in that case.

+		uartclk = strchr(options, ',');
+		if (uartclk && kstrtouint(uartclk, 0, &port->uartclk) < 0)

You are giving ",number" to kstrtouint, right? That won't work either ;).

regards,
--
js




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux