Hi Babu,
On 11/4/2022 1:00 PM, Babu Moger wrote:
> Add a new resource type RDT_RESOURCE_SMBA to handle the QoS
> enforcement policies on the external slow memory.
>
> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> Reviewed-by: Ingo Molnar <mingo@xxxxxxxxxx>
> ---
> arch/x86/kernel/cpu/resctrl/core.c | 12 ++++++++++++
> arch/x86/kernel/cpu/resctrl/internal.h | 1 +
> 2 files changed, 13 insertions(+)
>
> diff --git a/arch/x86/kernel/cpu/resctrl/core.c b/arch/x86/kernel/cpu/resctrl/core.c
> index 03cfbf0fe000..4b970e7192e8 100644
> --- a/arch/x86/kernel/cpu/resctrl/core.c
> +++ b/arch/x86/kernel/cpu/resctrl/core.c
> @@ -100,6 +100,18 @@ struct rdt_hw_resource rdt_resources_all[] = {
> .fflags = RFTYPE_RES_MB,
> },
> },
> + [RDT_RESOURCE_SMBA] =
> + {
> + .r_resctrl = {
> + .rid = RDT_RESOURCE_SMBA,
> + .name = "SMBA",
> + .cache_level = 3,
> + .domains = domain_init(RDT_RESOURCE_SMBA),
> + .parse_ctrlval = parse_bw,
> + .format_str = "%d=%*u",
> + .fflags = RFTYPE_RES_MB,
> + },
> + },
> };
>
Looking ahead at patch #5, I think that the initialization of
msr_base and msr_update (in rdt_init_res_defs_amd()) can be moved
here also.
> /*
> diff --git a/arch/x86/kernel/cpu/resctrl/internal.h b/arch/x86/kernel/cpu/resctrl/internal.h
> index 5f7128686cfd..43d9f6f5a931 100644
> --- a/arch/x86/kernel/cpu/resctrl/internal.h
> +++ b/arch/x86/kernel/cpu/resctrl/internal.h
> @@ -419,6 +419,7 @@ enum resctrl_res_level {
> RDT_RESOURCE_L3,
> RDT_RESOURCE_L2,
> RDT_RESOURCE_MBA,
> + RDT_RESOURCE_SMBA,
>
> /* Must be the last */
> RDT_NUM_RESOURCES,
>
>
Reinette
