On Tue, Nov 08, 2022 at 09:55:58PM +0100, Krzysztof Kozlowski wrote: > On 08/11/2022 17:33, Russell King (Oracle) wrote: > > Add a DT binding for the Apple Mac System Management Controller. > > Drop the second, redundant "binding" from subject. It's already in prefix. Yet another thing that's been there from the start... how many more things are you going to pick up in subsequent versions of the patch? When does this stop? In any case, taking your comment literally, "dt-bindings: mfd: add for Apple Mac System Management Controller" makes no sense, so presumably you want something more than that. In any case, I see several recent cases already merged which follow the pattern that I've used and that you've reviewed. > > Signed-off-by: Russell King (Oracle) <rmk+kernel@xxxxxxxxxxxxxxx> > > --- > > .../devicetree/bindings/mfd/apple,smc.yaml | 67 +++++++++++++++++++ > > 1 file changed, 67 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/mfd/apple,smc.yaml > > > > diff --git a/Documentation/devicetree/bindings/mfd/apple,smc.yaml b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > new file mode 100644 > > index 000000000000..014eba5a1bbc > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/mfd/apple,smc.yaml > > @@ -0,0 +1,67 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/mfd/apple,smc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Apple Mac System Management Controller > > + > > +maintainers: > > + - Hector Martin <marcan@xxxxxxxxx> > > + > > +description: > > + Apple Mac System Management Controller implements various functions > > + such as GPIO, RTC, power, reboot. > > + > > +properties: > > + compatible: > > + items: > > + - enum: > > + - apple,t6000-smc > > + - apple,t8103-smc > > + - apple,t8112-smc > > + - const: apple,smc > > + > > + reg: > > + items: > > + - description: SMC area > > + - description: SRAM area > > + > > + reg-names: > > + items: > > + - const: smc > > + - const: sram > > + > > + mboxes: > > + maxItems: 1 > > + > > + gpio: > > + $ref: /schemas/gpio/gpio-macsmc.yaml > > So this depends on other patch, so: > 1. You need mention the dependency in cover letter (nothing there), > 2. Re-order patches. > > The GPIO cannot go separate tree and this must be explicitly communicated. Sigh, getting an order that is sensible is really bloody difficult. I'm quite sure Lee is only going to want to apply the mfd bits. Then what do we do with the other bits? GPIO stuff via the GPIO tree, then wait a cycle before the rest can be merged. Or what? > > + > > +additionalProperties: false > > + > > +required: > > + - compatible > > + - reg > > + - reg-names > > + - mboxes > > + > > +examples: > > + - | > > + soc { > > + #address-cells = <2>; > > + #size-cells = <2>; > > + > > + smc@23e400000 { > > Usually these are called system-controller, to have a generic name (as > asked by DT spec). I'll defer to Hector for his response on this one, but you've had had plenty of opportunities to bring this up in the past - it's been there since the first posting. Frustrating is definitely the word for this drip-drip-drip review. -- RMK's Patch system: https://www.armlinux.org.uk/developer/patches/ FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
