On Tue, Nov 08, 2022 at 04:38:20PM +0100, наб wrote: > On Fri, Nov 04, 2022 at 03:50:02PM +0100, Thomas Bogendoerfer wrote: > > On Wed, Nov 02, 2022 at 12:05:30AM +0100, Ahelenia Ziemiańska wrote: > > > The only user is arch/mips/sgi-ip27/ip27-nmi.c; this file was imported > > > wholesale in 2.3.99pre9-1, and received only whitespace updates since > > > then. > > > > > > NMI_MAGIC isn't a magic number; it's unclear if it's actually used by > > > the firmware in some capacity or if it's a holdover from copying the SGI > > > code, but in the former case it's API and in the latter it's dead cruft. > > > > it's used by firmware and Linux code to register the NMI exception > > handler. > Great, I'll put that in the message. > > > Please leave arch/mips/include/asm/sn/nmi.h untouched as > > it's documents firmware NMI handler usage (even when we don't use it, yet). > "Yet". > This file appeared in 2.3.99pre9-1, and hasn't changed since. > I removed hard-coded assembly struct offsets, which we'll never use, > because we /haven't/ used them, and this part is implemented in C. > This file's my age, and these parts have been dead for just as long. > > Yet. it might be never used, but what's the problem with them ? Those files came from IRIX and "document" the firmware interface. And me as the MIPS maintainer wants to keep it there. Thomas. -- Crap can work. Given enough thrust pigs will fly, but it's not necessarily a good idea. [ RFC1925, 2.3 ]
