On 11/4/22 06:58, Andy Ren wrote:
> This patch allows a network interface to be renamed when the interface
> is up.
>
> Live renaming was added as a failover in the past, and there has been no
> arising issues of user space breaking. Furthermore, it seems that this
> flag was added because in the past, IOCTL was used for renaming, which
> would not notify the user space. Nowadays, it appears that the user
> space receives notifications regardless of the state of the network
> device (e.g. rtnetlink_event()). The listeners for NETDEV_CHANGENAME
> also do not strictly ensure that the netdev is up or not.
>
> Hence, this patch seeks to remove the live renaming flag and checks due
> to the aforementioned reasons.
>
> The changes are of following:
> - Remove IFF_LIVE_RENAME_OK flag declarations
> - Remove check in dev_change_name that checks whether device is up and
> if IFF_LIVE_RENAME_OK is set by the network device's priv_flags
> - Remove references of IFF_LIVE_RENAME_OK in the failover module
>
You have sent the patch twice, yet with same content ([1] and [2]),
so I reply to this latter version instead.
Please write the patch description in imperative mood ("make foo do
bar") instead of descriptive one like you have written ("this patch/commit
makes foo do bar").
Thanks.
[1]: https://lore.kernel.org/linux-doc/20221103224644.3806447-1-andy.ren@xxxxxxxxxxxxx/
[2]: https://lore.kernel.org/linux-doc/20221103235847.3919772-1-andy.ren@xxxxxxxxxxxxx/
--
An old man doll... just what I always wanted! - Clara
