On Tue, Nov 01, 2022 at 12:17:29PM -0700, Nicolin Chen wrote:
> On Tue, Oct 25, 2022 at 03:12:18PM -0300, Jason Gunthorpe wrote:
>
> > diff --git a/drivers/iommu/iommufd/io_pagetable.c b/drivers/iommu/iommufd/io_pagetable.c
> > new file mode 100644
> > index 00000000000000..27cbb652ee33cd
> > --- /dev/null
> > +++ b/drivers/iommu/iommufd/io_pagetable.c
>
> > +void iopt_enable_large_pages(struct io_pagetable *iopt)
> > +{
> > + down_write(&iopt->domains_rwsem);
> > + down_write(&iopt->iova_rwsem);
> > + WRITE_ONCE(iopt->disable_large_pages, false);
> > + iopt_calculate_iova_alignment(iopt);
>
> Coverity reports unchecked return value, perhaps WARN_ON()?
It really can't fail since the new alignment cannot increase, but OK,
just in case.
Jason
