Re: [PATCH bpf-next v3 1/1] doc: DEVMAPs and XDP_REDIRECT

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Oct 25, 2022 at 2:06 AM Maryam Tahhan <mtahhan@xxxxxxxxxx> wrote:
>
> On 24/10/2022 13:12, Jesper Dangaard Brouer wrote:
> >
> > First of all, I'm super happy that we are getting documentation added
> > for this.
> >
> > Comments inlined below.
> >
> > On 17/10/2022 11.47, mtahhan@xxxxxxxxxx wrote:
> >> diff --git a/Documentation/bpf/redirect.rst
> >> b/Documentation/bpf/redirect.rst
> >> new file mode 100644
> >> index 000000000000..5a0377a67ff0
> >> --- /dev/null
> >> +++ b/Documentation/bpf/redirect.rst
> >
> > Naming the file 'redirect.rst' is that in anticipating that TC-BPF also
> > support invoking the bpf_redirect helper?
> >
> > IMHO we should remember to *also* promote TC-BPF redirect, and it would
> > likely be good to have this in same file with XDP-redirect so end-users
> > see this.
> >
>
> So I will leave the name as is...

Please fold it into xdp doc that describes all return codes.
It's weird to have a separate file just for one of the return values
and not for the others.



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux