On Mon, Oct 24, 2022 at 08:35:00PM +0900, Akihiko Odaki wrote:
> acpi_video_get_backlight_type() is now deprecated.
The practical impact of this patch series on fujitsu-laptop is obviously
very minor assuming the new acpi_video_get_backlight_types() function
functions as advertised. Accordingly, as maintainer of fujitsu-laptop I
will defer to the opinions of others who maintain the lower level
infrastructure which is more substantially affected by the bulk of the
changes in this series.
I note that Hans has naked the series and I'm happy to go along with that.
Regards
jonathan
> Signed-off-by: Akihiko Odaki <akihiko.odaki@xxxxxxxxxx>
> ---
> drivers/platform/x86/fujitsu-laptop.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/platform/x86/fujitsu-laptop.c b/drivers/platform/x86/fujitsu-laptop.c
> index b543d117b12c..e820de39cb68 100644
> --- a/drivers/platform/x86/fujitsu-laptop.c
> +++ b/drivers/platform/x86/fujitsu-laptop.c
> @@ -387,7 +387,7 @@ static int acpi_fujitsu_bl_add(struct acpi_device *device)
> struct fujitsu_bl *priv;
> int ret;
>
> - if (acpi_video_get_backlight_type() != acpi_backlight_vendor)
> + if (!(acpi_video_get_backlight_types() & ACPI_BACKLIGHT_VENDOR))
> return -ENODEV;
>
> priv = devm_kzalloc(&device->dev, sizeof(*priv), GFP_KERNEL);
> @@ -819,7 +819,7 @@ static int acpi_fujitsu_laptop_add(struct acpi_device *device)
>
> /* Sync backlight power status */
> if (fujitsu_bl && fujitsu_bl->bl_device &&
> - acpi_video_get_backlight_type() == acpi_backlight_vendor) {
> + (acpi_video_get_backlight_types() & ACPI_BACKLIGHT_VENDOR)) {
> if (call_fext_func(fext, FUNC_BACKLIGHT, 0x2,
> BACKLIGHT_PARAM_POWER, 0x0) == BACKLIGHT_OFF)
> fujitsu_bl->bl_device->props.power = FB_BLANK_POWERDOWN;
> --
> 2.37.3
