On Thu, Oct 20, 2022 at 07:53:29PM +0200, Maciej Kwapulinski wrote: > From: Tomasz Jankowski <tomasz1.jankowski@xxxxxxxxx> > > As this is first ioctl in the series, the patch also adds common bits for > remaining ioctls Again, please read the documentation for what to do here, this is not helpful at all. > +int gna_getparam_ioctl(struct drm_device *dev, void *data, > + struct drm_file *file) > +{ > + struct gna_device *gna_priv = to_gna_device(dev); > + union gna_parameter *param = data; > + > + return gna_getparam(gna_priv, param); Wrong error value returned if you have an invalid ioctl :( greg k-h