Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: "kirill.shutemov@xxxxxxxxxxxxxxx" <kirill.shutemov@xxxxxxxxxxxxxxx>
Subject: Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack
From: "Edgecombe, Rick P" <rick.p.edgecombe@xxxxxxxxx>
Date: Mon, 3 Oct 2022 19:53:43 +0000
Accept-language: en-US
Cc: "bsingharora@xxxxxxxxx" <bsingharora@xxxxxxxxx>, "hpa@xxxxxxxxx" <hpa@xxxxxxxxx>, "Syromiatnikov, Eugene" <esyr@xxxxxxxxxx>, "peterz@xxxxxxxxxxxxx" <peterz@xxxxxxxxxxxxx>, "rdunlap@xxxxxxxxxxxxx" <rdunlap@xxxxxxxxxxxxx>, "keescook@xxxxxxxxxxxx" <keescook@xxxxxxxxxxxx>, "Yu, Yu-cheng" <yu-cheng.yu@xxxxxxxxx>, "dave.hansen@xxxxxxxxxxxxxxx" <dave.hansen@xxxxxxxxxxxxxxx>, "Eranian, Stephane" <eranian@xxxxxxxxxx>, "linux-mm@xxxxxxxxx" <linux-mm@xxxxxxxxx>, "fweimer@xxxxxxxxxx" <fweimer@xxxxxxxxxx>, "nadav.amit@xxxxxxxxx" <nadav.amit@xxxxxxxxx>, "jannh@xxxxxxxxxx" <jannh@xxxxxxxxxx>, "dethoma@xxxxxxxxxxxxx" <dethoma@xxxxxxxxxxxxx>, "linux-arch@xxxxxxxxxxxxxxx" <linux-arch@xxxxxxxxxxxxxxx>, "kcc@xxxxxxxxxx" <kcc@xxxxxxxxxx>, "bp@xxxxxxxxx" <bp@xxxxxxxxx>, "oleg@xxxxxxxxxx" <oleg@xxxxxxxxxx>, "hjl.tools@xxxxxxxxx" <hjl.tools@xxxxxxxxx>, "Yang, Weijiang" <weijiang.yang@xxxxxxxxx>, "Lutomirski, Andy" <luto@xxxxxxxxxx>, "pavel@xxxxxx" <pavel@xxxxxx>, "arnd@xxxxxxxx" <arnd@xxxxxxxx>, "Moreira, Joao" <joao.moreira@xxxxxxxxx>, "tglx@xxxxxxxxxxxxx" <tglx@xxxxxxxxxxxxx>, "mike.kravetz@xxxxxxxxxx" <mike.kravetz@xxxxxxxxxx>, "x86@xxxxxxxxxx" <x86@xxxxxxxxxx>, "linux-doc@xxxxxxxxxxxxxxx" <linux-doc@xxxxxxxxxxxxxxx>, "jamorris@xxxxxxxxxxxxxxxxxxx" <jamorris@xxxxxxxxxxxxxxxxxxx>, "john.allen@xxxxxxx" <john.allen@xxxxxxx>, "rppt@xxxxxxxxxx" <rppt@xxxxxxxxxx>, "mingo@xxxxxxxxxx" <mingo@xxxxxxxxxx>, "Shankar, Ravi V" <ravi.v.shankar@xxxxxxxxx>, "corbet@xxxxxxx" <corbet@xxxxxxx>, "linux-kernel@xxxxxxxxxxxxxxx" <linux-kernel@xxxxxxxxxxxxxxx>, "linux-api@xxxxxxxxxxxxxxx" <linux-api@xxxxxxxxxxxxxxx>, "gorcunov@xxxxxxxxx" <gorcunov@xxxxxxxxx>
In-reply-to: <20221003134006.yoye7dvywuec6bco@box.shutemov.name>
References: <20220929222936.14584-1-rick.p.edgecombe@intel.com> <20220929222936.14584-3-rick.p.edgecombe@intel.com> <20221003134006.yoye7dvywuec6bco@box.shutemov.name>

On Mon, 2022-10-03 at 16:40 +0300, Kirill A . Shutemov wrote:
> Hm. Shouldn't ARCH_HAS_SHADOW_STACK definition be in arch/Kconfig,
> not
> under arch/x86?
> 
> Also, I think "def_bool n" has the same meaning as just "bool", no?
> 
> > +
> > +config X86_SHADOW_STACK
> > +     prompt "X86 Shadow Stack"
> > +     def_bool n
> 
> Maybe just
> 
>         bool "X86 Shadow Stack"
> 
> ?
Yep, will change it. Thanks.

References:
- [PATCH v2 00/39] Shadowstacks for userspace
  - From: Rick Edgecombe
- [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack
  - From: Rick Edgecombe
- Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack
  - From: Kirill A . Shutemov

Prev by Date: Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack
Next by Date: Re: [PATCH v2 24/39] x86/cet/shstk: Add user-mode shadow stack support
Previous by thread: Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack
Next by thread: Re: [PATCH v2 02/39] x86/cet/shstk: Add Kconfig option for Shadow Stack
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]