On Tue, Jun 25, 2013 at 02:56:10PM +0300, Luciano Coelho wrote: > On Tue, 2013-06-25 at 14:12 +0300, Felipe Balbi wrote: > > On Tue, Jun 25, 2013 at 11:35:30AM +0300, Luciano Coelho wrote: > > > +- tcxoclock: the internal WLAN TCXO clock frequency (required for > > > + WiLink7 not used for WiLink6 and WiLink8). Must be one of the > > > + following: > > > + 0 = 19.200 MHz > > > + 1 = 26.000 MHz > > > + 2 = 38.400 MHz > > > + 3 = 52.000 MHz > > > + 4 = 16.368 MHz > > > + 5 = 32.736 MHz > > > + 6 = 16.800 MHz > > > + 7 = 33.600 MHz > > > > DTS files are pre-processed, so you could add defines in a header and > > share the header between DTS and driver. Could help you having: > > > > tcxoclock = WILINK_19_200MHz; > > > > instead of > > > > tcxoclock = 0; > > I don't see any .dts file really doing this. There are some imx*.dtsi > files that include imx*.h files, but I don't see these headers being > included in any source code file. > > In fact, we already have all these values defined in > include/linux/wl12xx.h, so it could be nice to reuse. But the > cross-directory includes would look "funny". And I think it's a bit > overkill. > > These values are actually used by the firmware itself, not only the > driver, so they are also platform independent and not related to the OS. fair enough, then there's no chance they'll change all of a sudden. -- balbi
Attachment:
signature.asc
Description: Digital signature
