RE: [PATCH v5 1/2] x86/resctrl: Fix min_cbm_bits for AMD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> AMD systems support zero CBM (capacity bit mask) for cache allocation.
> That is reflected in rdt_init_res_defs_amd() by:
> 
>         r->cache.arch_has_empty_bitmaps = true;
> 
> However given the unified code in cbm_validate(), checking for:
>         val == 0 && !arch_has_empty_bitmaps
> 
> is not enough because of another check in cbm_validate():
> 
>         if ((zero_bit - first_bit) < r->cache.min_cbm_bits)
> 
> The default value of r->cache.min_cbm_bits = 1.
> 
> Leading to:
> 
>         $ cd /sys/fs/resctrl
>         $ mkdir foo
>         $ cd foo
>         $ echo L3:0=0 > schemata
>           -bash: echo: write error: Invalid argument
>         $ cat /sys/fs/resctrl/info/last_cmd_status
>           Need at least 1 bits in the mask
> 
> Fix the issue by initializing the min_cbm_bits to 0 for AMD.
> Also, remove the default setting of min_cbm_bits and initialize it separately.
> 
> After the fix
>         $ cd /sys/fs/resctrl
>         $ mkdir foo
>         $ cd foo
>         $ echo L3:0=0 > schemata
>         $ cat /sys/fs/resctrl/info/last_cmd_status
>           ok
> 
> Link: https://lore.kernel.org/lkml/20220517001234.3137157-1-
> eranian@xxxxxxxxxx/
> Fixes: 316e7f901f5a ("x86/resctrl: Add struct rdt_cache::arch_has_{sparse,
> empty}_bitmaps")
> Co-developed-by: Stephane Eranian <eranian@xxxxxxxxxx>
> Signed-off-by: Stephane Eranian <eranian@xxxxxxxxxx>
> Signed-off-by: Babu Moger <babu.moger@xxxxxxx>
> Reviewed-by: Ingo Molnar <mingo@xxxxxxxxxx>
> Reviewed-by: James Morse <james.morse@xxxxxxx>
> Reviewed-by: Reinette Chatre <reinette.chatre@xxxxxxxxx>

Reviewed-by: Fenghua Yu <fenghua.yu@xxxxxxxxx>




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux