On Tue, Aug 23, 2022 at 03:25:16PM -0700, Evan Green wrote: > This series adopts that primitive as a foundation, tweaking and building > on it a bit. Where Matthew's series used the TPM-backed key to encrypt a > hash of the image, this series uses the key directly as a gcm(aes) > encryption key, which the kernel uses to encrypt and decrypt the > hibernate image in chunks of 16 pages. This provides both encryption and > integrity, which turns out to be a noticeable performance improvement over > separate passes for encryption and hashing. I like this series! I would ask that someone more familiar with the cryptographic constraints here confirm that the primitives you're using are going to actually provide you the constraints you want (i.e. encryption, integrity, etc). My understanding is that gcm(aes) is exactly right, but I Am Not A Cryptographer. ;) I'll reply more to individual patches ... -- Kees Cook
