On Sun, 11 Sep 2022 09:59:20 +0000 Pasha Tatashin <pasha.tatashin@xxxxxxxxxx> wrote: > From: Pasha Tatashin <tatashin@xxxxxxxxxx> > > Page table check when detects errors panics the kernel. Let instead, > print a warning, and panic only when specifically requested via kernel > parameter: > > page_table_check=panic > > The discussion about using panic vs. warn is here: > https://lore.kernel.org/linux-mm/20220902232732.12358-1-rick.p.edgecombe@xxxxxxxxx The changelog doesn't actually describe the reason for making this change. Somebody obviously wants pagetable check errors to no longer panic the kernel, but why?? (The same can be said of the [2/3] changelog). Also, should we be changing the default? People who like the panic will get a big surprise when they find out that they should have added a kernel parameter to get the old behaviour back. It would be less disruptive to default to panic unless page_table_check=warn was added. If there's a solid reason for changing the default, it should be changelogged. And if that reason is generally agreed to, perhaps the kernel should print a warning at boot if neither page_table_check=panic nor page_table_check=warn were provided. To tell people that the default has been changed.
