Hi Joe, Thanks for your feedback. On 2022-09-09 10:57:10 -0700, Joe Perches wrote: > I think it's better to make sure that there is a likely SHA1 of some > minimum length after the fixes line. > > And a relatively common defect is to have the word "commit" after fixes. > > e.g.: > > Fixes commit 554c0a3abf216 ("staging: Add rtl8723bs sdio wifi driver"). > Fixes commit a2c60d42d97c ("Add files for new driver - part 16"). > > So maybe: > > if (!$in_header_lines && > $line =~ /^\s*fixes:?\s*(?:commit\s*)?[0-9a-f]{5,}\b/i) I'm sorry I just sent out v6 and missed this comment, which I think is a great idea. I will let v6 stew for a day or two in case there is other feedback and then spin a v7 with this addressed. -- Kind Regards, Niklas Söderlund