Andrii Nakryiko <andrii.nakryiko@xxxxxxxxx> writes: > On Tue, Sep 6, 2022 at 3:50 AM Donald Hunter <donald.hunter@xxxxxxxxx> wrote: >> >> Daniel Borkmann <daniel@xxxxxxxxxxxxx> writes: >> >> > On 8/29/22 11:14 AM, Donald Hunter wrote: >> >> Run make in list of subdirs to build generated sources and migrate >> >> userspace-api/media to use this instead of being a special case. >> >> Signed-off-by: Donald Hunter <donald.hunter@xxxxxxxxx> >> > >> > Jonathan, given this touches Documentation/Makefile, could you ACK if >> > it looks good to you? Noticed both patches don't have doc: $subj prefix, >> > but that's something we could fix up. >> > >> > Maybe one small request, would be nice to build Documentation/bpf/libbpf/ >> > also with every BPF CI run to avoid breakage of program_types.csv. Donald >> > could you check if feasible? Follow-up might be ok too, but up to Andrii. >> >> Sure, I can look at what is needed for the BPF CI run. >> > > Daniel (Mueller, not Borkmann), is this something that can be added to BPF CI? It looks to me like it can be added to BPF CI if we change docs/conf.py to call a new make target in docs/sphinx/Makefile. Hopefully Daniel can confirm whether this is the case. Given that the tree layouts of the kernel and libbpf are very different I think we need to do one of: 1. Use a separate a .csv generator script with dedicated makefiles per project. 2. Move this entirely to libbpf and include a readthedocs URL in index.rst in the same way as currently done for the API docs. I think my preference would be for 2. Thanks Donald.
