Hello Joe,
On 2022-09-05 11:00:35 -0700, Joe Perches wrote:
> On Mon, 2022-09-05 at 12:49 +0200, Niklas Söderlund wrote:
> > Hi Joe,
> >
> > Thanks for your feedback.
> >
> > On 2022-08-29 23:06:43 -0400, Joe Perches wrote:
> > > > + if ($line =~
> > > > /(fixes:)\s+([0-9a-f]{5,})\s+($balanced_parens)/i) {
> > >
> > > Maybe use fixes:? so the colon is not required in poorly formed uses
> >
> > I tried that but I think it brings more problems then it is worth. With
> > that change the check would run for each line of the commit message that
> > begins with the string 'fixes', not just in the tags section of the
> > message. So it would warn for the commit message,
>
> I think it's not a problem.
> Look at the results of:
>
> $ git log -100000 --no-merges --format=email --grep="^fixes" -i | \
> grep -i -P -oh '^fixes:?\s*[0-9a-f]{5,}\s*..' | \
> sed -r -e 's/^(fixes:?\s*)[0-9a-f]+/\1/i' | \
> sort | uniq -c | sort -rn | head -20
> 73974 Fixes: ("
> 1345 Fixes: ('
> 399 Fixes:
> 246 Fixes: (A
> 215 Fixes: ("
> 172 Fixes: (c
> 121 Fixes: (s
> 114 Fixes: (d
> 110 Fixes: (P
> 98 Fixes: (i
> 90 Fixes: (m
> 86 Fixes: (n
> 78 Fixes: :
> 57 Fixes ("
> 51 Fixes: "n
> 47 Fixes: (a
> 46 Fixes: (t
> 43 fixes: ("
> 42 Fixes: (p
> 41 Fixes: ('
Thanks for checking this. With this background I agree with you, there
is no problem here. I will spin a v3 with your suggestion.
>
--
Kind Regards,
Niklas Söderlund
