On Thu, Sep 01, 2022 at 12:34:34PM -0700, Guenter Roeck wrote: > On 9/1/22 12:09, Kees Cook wrote: > > [...] > > -If a caller is using non-NUL-terminated strings, strncpy() can > > -still be used, but destinations should be marked with the `__nonstring > > +If a caller is using non-NUL-terminated strings, strtomem() should be > > +be used, and the destinations should be marked with the `__nonstring > > s/be // Thanks! > > [...] > > +++ b/include/linux/fortify-string.h > > @@ -77,6 +77,36 @@ extern char *__underlying_strncpy(char *p, const char *q, __kernel_size_t size) > > #define POS __pass_object_size(1) > > #define POS0 __pass_object_size(0) > > +/** strncpy - Copy a string to memory with non-guaranteed NUL padding > > Does that need a newline before strncpy() ? What do you mean here? I think this is valid kerndoc, but I'll double-check. (And will continue in the neighboring htmldoc build thread.) -Kees -- Kees Cook