Le 30/08/2022 à 22:14, Andy Shevchenko a écrit : > On Mon, Aug 29, 2022 at 7:18 PM Christophe Leroy > <christophe.leroy@xxxxxxxxxx> wrote: >> >> In the preparation of getting completely rid of static gpiobase >> allocation in the future, emit a warning in drivers still doing so. > > ... > >> + dev_warn(&gdev->dev, "Static allocation of GPIO base is " >> + "deprecated, use dynamic allocation."); > > First of all, do not split string literals. Second, you forgot '\n'. > Then I get a line longer than 100 chars, is that acceptable ? Since commit 5fd29d6ccbc9 ("printk: clean up handling of log-levels and newlines"), "\n" are just visual pollution, aren't they ? Christophe