Hi Sean, I love your patch! Perhaps something to improve: [auto build test WARNING on net-next/master] url: https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/net-phy-Add-1000BASE-KX-interface-mode/20220831-054425 base: https://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git 146ecbac1d327e7ed2153cfb3ef880166dc2b312 config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20220831/202208311035.zXZ42EG5-lkp@xxxxxxxxx/config) compiler: sh4-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/96d58b1eb1e74558860112250f067f5ff250e31f git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Sean-Anderson/net-phy-Add-1000BASE-KX-interface-mode/20220831-054425 git checkout 96d58b1eb1e74558860112250f067f5ff250e31f # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=sh SHELL=/bin/bash drivers/net/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): drivers/net/phy/phy-core.c: In function 'phy_interface_num_ports': >> drivers/net/phy/phy-core.c:86:9: warning: enumeration value 'PHY_INTERFACE_MODE_1000BASEKX' not handled in switch [-Wswitch] 86 | switch (interface) { | ^~~~~~ vim +/PHY_INTERFACE_MODE_1000BASEKX +86 drivers/net/phy/phy-core.c da4625ac2637e4 Russell King 2017-07-25 76 c04ade27cb7b95 Maxime Chevallier 2022-08-17 77 /** c04ade27cb7b95 Maxime Chevallier 2022-08-17 78 * phy_interface_num_ports - Return the number of links that can be carried by c04ade27cb7b95 Maxime Chevallier 2022-08-17 79 * a given MAC-PHY physical link. Returns 0 if this is c04ade27cb7b95 Maxime Chevallier 2022-08-17 80 * unknown, the number of links else. c04ade27cb7b95 Maxime Chevallier 2022-08-17 81 * c04ade27cb7b95 Maxime Chevallier 2022-08-17 82 * @interface: The interface mode we want to get the number of ports c04ade27cb7b95 Maxime Chevallier 2022-08-17 83 */ c04ade27cb7b95 Maxime Chevallier 2022-08-17 84 int phy_interface_num_ports(phy_interface_t interface) c04ade27cb7b95 Maxime Chevallier 2022-08-17 85 { c04ade27cb7b95 Maxime Chevallier 2022-08-17 @86 switch (interface) { c04ade27cb7b95 Maxime Chevallier 2022-08-17 87 case PHY_INTERFACE_MODE_NA: c04ade27cb7b95 Maxime Chevallier 2022-08-17 88 return 0; c04ade27cb7b95 Maxime Chevallier 2022-08-17 89 case PHY_INTERFACE_MODE_INTERNAL: c04ade27cb7b95 Maxime Chevallier 2022-08-17 90 case PHY_INTERFACE_MODE_MII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 91 case PHY_INTERFACE_MODE_GMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 92 case PHY_INTERFACE_MODE_TBI: c04ade27cb7b95 Maxime Chevallier 2022-08-17 93 case PHY_INTERFACE_MODE_REVMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 94 case PHY_INTERFACE_MODE_RMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 95 case PHY_INTERFACE_MODE_REVRMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 96 case PHY_INTERFACE_MODE_RGMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 97 case PHY_INTERFACE_MODE_RGMII_ID: c04ade27cb7b95 Maxime Chevallier 2022-08-17 98 case PHY_INTERFACE_MODE_RGMII_RXID: c04ade27cb7b95 Maxime Chevallier 2022-08-17 99 case PHY_INTERFACE_MODE_RGMII_TXID: c04ade27cb7b95 Maxime Chevallier 2022-08-17 100 case PHY_INTERFACE_MODE_RTBI: c04ade27cb7b95 Maxime Chevallier 2022-08-17 101 case PHY_INTERFACE_MODE_XGMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 102 case PHY_INTERFACE_MODE_XLGMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 103 case PHY_INTERFACE_MODE_MOCA: c04ade27cb7b95 Maxime Chevallier 2022-08-17 104 case PHY_INTERFACE_MODE_TRGMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 105 case PHY_INTERFACE_MODE_USXGMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 106 case PHY_INTERFACE_MODE_SGMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 107 case PHY_INTERFACE_MODE_SMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 108 case PHY_INTERFACE_MODE_1000BASEX: c04ade27cb7b95 Maxime Chevallier 2022-08-17 109 case PHY_INTERFACE_MODE_2500BASEX: c04ade27cb7b95 Maxime Chevallier 2022-08-17 110 case PHY_INTERFACE_MODE_5GBASER: c04ade27cb7b95 Maxime Chevallier 2022-08-17 111 case PHY_INTERFACE_MODE_10GBASER: c04ade27cb7b95 Maxime Chevallier 2022-08-17 112 case PHY_INTERFACE_MODE_25GBASER: c04ade27cb7b95 Maxime Chevallier 2022-08-17 113 case PHY_INTERFACE_MODE_10GKR: c04ade27cb7b95 Maxime Chevallier 2022-08-17 114 case PHY_INTERFACE_MODE_100BASEX: c04ade27cb7b95 Maxime Chevallier 2022-08-17 115 case PHY_INTERFACE_MODE_RXAUI: c04ade27cb7b95 Maxime Chevallier 2022-08-17 116 case PHY_INTERFACE_MODE_XAUI: c04ade27cb7b95 Maxime Chevallier 2022-08-17 117 return 1; c04ade27cb7b95 Maxime Chevallier 2022-08-17 118 case PHY_INTERFACE_MODE_QSGMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 119 case PHY_INTERFACE_MODE_QUSGMII: c04ade27cb7b95 Maxime Chevallier 2022-08-17 120 return 4; c04ade27cb7b95 Maxime Chevallier 2022-08-17 121 case PHY_INTERFACE_MODE_MAX: c04ade27cb7b95 Maxime Chevallier 2022-08-17 122 WARN_ONCE(1, "PHY_INTERFACE_MODE_MAX isn't a valid interface mode"); c04ade27cb7b95 Maxime Chevallier 2022-08-17 123 return 0; c04ade27cb7b95 Maxime Chevallier 2022-08-17 124 } c04ade27cb7b95 Maxime Chevallier 2022-08-17 125 return 0; c04ade27cb7b95 Maxime Chevallier 2022-08-17 126 } c04ade27cb7b95 Maxime Chevallier 2022-08-17 127 EXPORT_SYMBOL_GPL(phy_interface_num_ports); c04ade27cb7b95 Maxime Chevallier 2022-08-17 128 -- 0-DAY CI Kernel Test Service https://01.org/lkp
