Hi Randy, On Fri, Aug 26, 2022 at 04:06:14PM -0700, Randy Dunlap wrote: > Hi Jules, > > On 8/26/22 09:56, Jules Maselbas wrote: > > diff --git a/Documentation/networking/switchdev.rst b/Documentation/networking/switchdev.rst > > index f1f4e6a85a29..6a0c2cc722eb 100644 > > --- a/Documentation/networking/switchdev.rst > > +++ b/Documentation/networking/switchdev.rst > > @@ -161,7 +161,7 @@ The switchdev driver can know a particular port's position in the topology by > > monitoring NETDEV_CHANGEUPPER notifications. For example, a port moved into a > > bond will see it's upper master change. If that bond is moved into a bridge, > > the bond's upper master will change. And so on. The driver will track such > > -movements to know what position a port is in in the overall topology by > > +movements to know what position a port is in the overall topology by > > I don't think any change is needed here. > The rest look good to me. You're right. > > > registering for netdevice events and acting on NETDEV_CHANGEUPPER. > > > > There are likely more duplicated words. > > /methinks that you have barely scratched the surface. :) yeah... "am doing my part" ;) Thanks for your time, will send a v5 shortly