Fri, Aug 26, 2022 at 02:40:20AM CEST, jacob.e.keller@xxxxxxxxx wrote: > > >> -----Original Message----- >> From: Jiri Pirko <jiri@xxxxxxxxxxx> >> Sent: Tuesday, July 26, 2022 12:47 AM >> To: Keller, Jacob E <jacob.e.keller@xxxxxxxxx> >> Cc: netdev@xxxxxxxxxxxxxxx; Jonathan Corbet <corbet@xxxxxxx>; Jiri Pirko >> <jiri@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet >> <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni >> <pabeni@xxxxxxxxxx>; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; >> David Ahern <dsahern@xxxxxxxxxx>; Stephen Hemminger >> <stephen@xxxxxxxxxxxxxxxxxx>; linux-doc@xxxxxxxxxxxxxxx >> Subject: Re: [iproute2-next v3 2/3] mnlg: add function to get >> CTRL_ATTR_MAXATTR value >> >> Mon, Jul 25, 2022 at 10:56:49PM CEST, jacob.e.keller@xxxxxxxxx wrote: >> >Add a new function to extract the CTRL_ATTR_MAXATTR attribute of the >> >CTRL_CMD_GETFAMILY request. This will be used to allow reading the >> >maximum supported devlink attribute of the running kernel in an upcoming >> >change. >> > >> >Signed-off-by: Jacob Keller <jacob.e.keller@xxxxxxxxx> >> >> Reviewed-by: Jiri Pirko <jiri@xxxxxxxxxx> > >I had a new approach which just extracted maxattr and stored it hwnever we call CTRL_CMD_GETFAMILY, which I think is a preferable approach to this. That was part of the series I sent recently to support policy checking. I think I'd prefer that route now over this patch. Send it :) > >Thanks, >Jake
