Re: [PATCH net-next v2 2/6] netlink: add support for ext_ack missing attributes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2022-08-24 at 19:41 -0700, Jakub Kicinski wrote:
> 
> + * @miss_type: attribute type which was missing
> + * @miss_nest: nest missing an attribute (NULL if missing top level attr)

nit: maybe use %NULL for appropriate formatting in generated
documentation

>  	const char *_msg;
>  	const struct nlattr *bad_attr;
>  	const struct nla_policy *policy;
> +	const void *miss_nest;

Can be 'const struct nlattr *' now, no? No longer points to a random
header.

johannes




[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux