On Fri, Aug 12, 2022 at 08:36:17PM +0800, Chengming Zhou <zhouchengming@xxxxxxxxxxxxx> wrote: > Could you help take a look if there is anything to improve? Thanks, just a little nit. > + The reason this control attribute exists is that PSI accounts stalls for > + each cgroup separately and aggregates it at each level of the hierarchy. > + This may cause non-negligible overhead for some workloads when under > + deep level of the hierarchy, in which case this control attribute can > + be used to disable PSI accounting in the cgroups. s/in the cgroups/in the non-leaf cgroups/ or s/in the cgroups/in the uninteresting cgroups/ (I'm concerned that it may result in lots of disabling if you want the performance. I'll expand on it in 2nd subthread.) Michal