On Sat, Aug 13, 2022 at 12:21 PM Tales Aparecida <tales.aparecida@xxxxxxxxx> wrote: > > Missing closing block-quote > > Signed-off-by: Tales Aparecida <tales.aparecida@xxxxxxxxx> > --- This is fine. A couple of minor nitpicks: 1. A slightly more descriptive commit title would be nice (e.g. "fix missing quote in run_wrapper") 2. The whole --jobs=`nproc --all` bit shouldn't be necessary anymore, thanks to: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/commit/?id=ad659ccb5412874c6a89d3588cb18857c00e9d0f Neither of those seem worth sending another version out for, but may be worth keeping in mind in the future. Reviewed-by: David Gow <davidgow@xxxxxxxxxx> Cheers, -- David > Documentation/dev-tools/kunit/run_wrapper.rst | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Documentation/dev-tools/kunit/run_wrapper.rst b/Documentation/dev-tools/kunit/run_wrapper.rst > index cce203138fb7..db1e867820e7 100644 > --- a/Documentation/dev-tools/kunit/run_wrapper.rst > +++ b/Documentation/dev-tools/kunit/run_wrapper.rst > @@ -30,7 +30,7 @@ We may want to use the following options: > > .. code-block:: > > - ./tools/testing/kunit/kunit.py run --timeout=30 --jobs=`nproc --all > + ./tools/testing/kunit/kunit.py run --timeout=30 --jobs=`nproc --all` > > - ``--timeout`` sets a maximum amount of time for tests to run. > - ``--jobs`` sets the number of threads to build the kernel. > -- > 2.37.1 > > -- > You received this message because you are subscribed to the Google Groups "KUnit Development" group. > To unsubscribe from this group and stop receiving emails from it, send an email to kunit-dev+unsubscribe@xxxxxxxxxxxxxxxx. > To view this discussion on the web visit https://groups.google.com/d/msgid/kunit-dev/20220813042055.136832-2-tales.aparecida%40gmail.com.
