Hi Cornelia, Thanks for the review. This is my first approach to virtio and I had to make some assumptions myself from reading the code and the spec, so I expected lots of corrections. On mar, ago 02 2022 at 17:55:43, Cornelia Huck <cohuck@xxxxxxxxxx> wrote: > I think kerneldoc updates should be split out into a separate patch. Ack, I'll split them in the next version. > There are devices that implement virtio in hardware. > ... > Please also mention CCW (s390 channel devices), as Linux supports it as > well. I'll add that to v2. > Should be the "virtio-console (...) device when using PCI...", I guess? You're right, I was focusing on the concrete example I was testing instead. > v1.2 is out now :) > > (I think it would be better to refer to the base spec directory?) Do you mean this? https://docs.oasis-open.org/virtio/virtio/ Or should I link the source repo instead? https://github.com/oasis-tcs/virtio-spec > Chapter 5 ("Device Types") in the virtio specification [1] > > (and add the same reference as above in this file)? Got it. > Very important point here: Don't add a device driver for a device that > has no reserved device id in the spec. Preferably, don't add a device > driver if no spec is available (it is useful to develop > devices/drivers/spec at the same time to avoid incompatibilities/fixups > later; and you can consider a device spec "final" if it has been > accepted into the spec, even if it isn't in a released version yet.) > ... > Don't do that :) You need to make clear that VIRTIO_DEVICE_DUMMY is only > a placeholder. Thanks, I'll make sure to rework this and to mention that you shouldn't add a new out-of-spec device id. Cheers, Ricardo
