> -----Original Message----- > From: Stephen Hemminger <stephen@xxxxxxxxxxxxxxxxxx> > Sent: Monday, July 25, 2022 2:13 PM > To: Keller, Jacob E <jacob.e.keller@xxxxxxxxx> > Cc: netdev@xxxxxxxxxxxxxxx; Jonathan Corbet <corbet@xxxxxxx>; Jiri Pirko > <jiri@xxxxxxxxxx>; David S. Miller <davem@xxxxxxxxxxxxx>; Eric Dumazet > <edumazet@xxxxxxxxxx>; Jakub Kicinski <kuba@xxxxxxxxxx>; Paolo Abeni > <pabeni@xxxxxxxxxx>; Nguyen, Anthony L <anthony.l.nguyen@xxxxxxxxx>; > David Ahern <dsahern@xxxxxxxxxx>; linux-doc@xxxxxxxxxxxxxxx > Subject: Re: [iproute2-next v3 3/3] devlink: add dry run attribute support to > devlink flash > > On Mon, 25 Jul 2022 13:56:50 -0700 > Jacob Keller <jacob.e.keller@xxxxxxxxx> wrote: > > > To avoid potential issues, only allow the attribute to be added to > > commands when the kernel recognizes it. This is important because some > > commands do not perform strict validation. If we were to add the > > attribute without this check, an old kernel may silently accept the > > command and perform an update even when dry_run was requested. > > Sigh. Looks like the old kernels are buggy. The workaround in userspace > is also likely to be source of bugs. We've known about this problem for a while.. I think its more complicated than just switching to strict validation, since ideally we want to validate attributes for each command separately, and not just accepting all known attributes for a given command. Thanks, Jake
