On Fri, Jun 14, 2013 at 12:20 PM, Philip Avinash
<avinashphilipk@xxxxxxxxx> wrote:
> From: KV Sujith <sujithkv@xxxxxx>
>
> - Add of_device_id for Davinci GPIO driver.
> - Add function to populate data from DT.
> - Modify the probe to read from DT if DT match is found.
> - Add DT binding documentation for Davinci GPIO properties in a new file
> gpio-davinci.txt located at Documentation/devicetree/bindings/gpio/.
>
> Signed-off-by: KV Sujith <sujithkv@xxxxxx>
> Signed-off-by: Philip Avinash <avinashphilip@xxxxxx>
> ---
> Changes since v1:
> - description for interrupts changed to reflecti
> interrupt array usage.
(...)
> +static struct davinci_gpio_platform_data *davinci_gpio_set_pdata_of(
> + struct platform_device *pdev)
> +{
> + struct device_node *dn = pdev->dev.of_node;
> + struct davinci_gpio_platform_data *pdata;
> + u32 val, ret;
> +
> + pdata = devm_kzalloc(&pdev->dev, sizeof(*pdata), GFP_KERNEL);
> + if (pdata) {
Instead of this arrow pattern:
if (!pdata) {
dev_err( ... "out of memory allocating platform data");
return NULL;
}
And de-indent the rest.
With that change:
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
I guess this may go through the DaVinci tree with the rest of the DaVinci
patches?
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-doc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
