Re: [PATCH v4 19/41] doc-dyndbg: edit dynamic-debug-howto for brevity, audience

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Jul 18, 2022 at 7:44 PM Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote:
>
> On 7/19/22 02:46, Jim Cromie wrote:
> > -You can view the currently configured behaviour of all the debug
> > -statements via::
> > +You can view the currently configured behaviour in the *prdbg* catalog:
> >
> > -  nullarbor:~ # cat <debugfs>/dynamic_debug/control
> > +  :#> head -n7 /proc/dynamic_debug/control
> >    # filename:lineno [module]function flags format
> > -  net/sunrpc/svc_rdma.c:323 [svcxprt_rdma]svc_rdma_cleanup =_ "SVCRDMA Module Removed, deregister RPC RDMA transport\012"
> > -  net/sunrpc/svc_rdma.c:341 [svcxprt_rdma]svc_rdma_init =_ "\011max_inline       : %d\012"
> > -  net/sunrpc/svc_rdma.c:340 [svcxprt_rdma]svc_rdma_init =_ "\011sq_depth         : %d\012"
> > -  net/sunrpc/svc_rdma.c:338 [svcxprt_rdma]svc_rdma_init =_ "\011max_requests     : %d\012"
> > -  ...
> > +  init/main.c:1179 [main]initcall_blacklist =_ "blacklisting initcall %s\012
> > +  init/main.c:1218 [main]initcall_blacklisted =_ "initcall %s blacklisted\012"
> > +  init/main.c:1424 [main]run_init_process =_ "  with arguments:\012"
> > +  init/main.c:1426 [main]run_init_process =_ "    %s\012"
> > +  init/main.c:1427 [main]run_init_process =_ "  with environment:\012"
> > +  init/main.c:1429 [main]run_init_process =_ "    %s\012"
> >
>
> The block above is screen output, so keep using literal code block
> marker (::).
>

yup.


> What isn't described in the patch description is $PS1, which changed
> to just root prompt (without username).
>

I lumped it under general de-cluttering.
the alias makes the pwd irrelevant, so no point in showing it.
I'll add a note to the commit-msg

>
> > +Kernel Configuration
> > +====================
> > +
> > +Dynamic Debug is enabled via kernel config items:
> > +
> > +  CONFIG_DYNAMIC_DEBUG=y     # build catalog, enables CORE
> > +  CONFIG_DYNAMIC_DEBUG_CORE=y        # enable mechanics only, skip catalog
> > +
>
> Also use literal code blockhere
>
> > +Fedora's distro-kernel has both, and has 7250 *prdbgs*.  Each callsite
> > +record uses 56 bytes, so the impact on memory is non-trivial.
> > +
> > +If you do not want to enable dynamic debug globally (i.e. in some embedded
> > +system), you may set ``CONFIG_DYNAMIC_DEBUG_CORE`` as basic support of dynamic
> > +debug and add ``ccflags := -DDYNAMIC_DEBUG_MODULE`` into the Makefile of any
> > +modules which you'd like to dynamically debug later.
> > +
>
> This assumes one has Fedora installed, so I think this should be
> written as distro-agnostic.
>

I just used the specifics I knew.
The point was size info tradeoffs for folks building their own kernels.
I'll just drop it, the numbers are subject to change anyway.

> Thanks.
>
> --
> An old man doll... just what I always wanted! - Clara



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux