Hi Jarrett, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on hid/for-next] [also build test WARNING on dtor-input/next robh/for-next linus/master v5.19-rc6 next-20220711] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jarrett-Schultz/Add-spi-hid-transport-for-HID-over-SPI-bus/20220708-010203 base: https://git.kernel.org/pub/scm/linux/kernel/git/hid/hid.git for-next config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20220712/202207120839.Ga8kjAG8-lkp@xxxxxxxxx/config) compiler: clang version 15.0.0 (https://github.com/llvm/llvm-project 77a38f6839980bfac61babb40d83772c51427011) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/d0121c2f2d1bb21824555c34c233dd3fbc6aee96 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jarrett-Schultz/Add-spi-hid-transport-for-HID-over-SPI-bus/20220708-010203 git checkout d0121c2f2d1bb21824555c34c233dd3fbc6aee96 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=i386 SHELL=/bin/bash drivers/hid/spi-hid/ drivers/md/ drivers/net/ethernet/marvell/prestera/ drivers/vfio/pci/mlx5/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All warnings (new ones prefixed by >>): >> drivers/hid/spi-hid/spi-hid-core.c:193:20: warning: 'const' type qualifier on return type has no effect [-Wignored-qualifiers] static const char *const spi_hid_power_mode_string(u8 power_state) ^~~~~~ >> drivers/hid/spi-hid/spi-hid-core.c:691:4: warning: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Wformat] hid->vendor, hid->product); ^~~~~~~~~~~ drivers/hid/spi-hid/spi-hid-core.c:691:17: warning: format specifies type 'unsigned short' but the argument has type '__u32' (aka 'unsigned int') [-Wformat] hid->vendor, hid->product); ^~~~~~~~~~~~ drivers/hid/spi-hid/spi-hid-core.c:1318:13: error: incompatible function pointer types initializing 'void (*)(struct spi_device *)' with an expression of type 'int (struct spi_device *)' [-Werror,-Wincompatible-function-pointer-types] .remove = spi_hid_remove, ^~~~~~~~~~~~~~ 3 warnings and 1 error generated. -- In file included from drivers/hid/spi-hid/trace.c:9: In file included from drivers/hid/spi-hid/./spi-hid_trace.h:194: In file included from include/trace/define_trace.h:102: In file included from include/trace/trace_events.h:237: >> drivers/hid/spi-hid/./spi-hid_trace.h:140:92: warning: more '%' conversions than data arguments [-Wformat-insufficient-args] TP_printk("spi%d.%d: (%04x:%04x v%d) HID v%d.%d state i:%d p:%d len i:%d o:%d r:%d flags %c", ~^ include/trace/stages/stage3_trace_output.h:9:33: note: expanded from macro 'TP_printk' #define TP_printk(fmt, args...) fmt "\n", args ^~~ include/trace/trace_events.h:203:27: note: expanded from macro 'DECLARE_EVENT_CLASS' trace_event_printf(iter, print); \ ^~~~~ 1 warning generated. vim +/const +193 drivers/hid/spi-hid/spi-hid-core.c 192 > 193 static const char *const spi_hid_power_mode_string(u8 power_state) 194 { 195 switch (power_state) { 196 case SPI_HID_POWER_MODE_ON: 197 return "d0"; 198 case SPI_HID_POWER_MODE_SLEEP: 199 return "d2"; 200 case SPI_HID_POWER_MODE_OFF: 201 return "d3"; 202 case SPI_HID_POWER_MODE_WAKING_SLEEP: 203 return "d3*"; 204 default: 205 return "unknown"; 206 } 207 } 208 -- 0-DAY CI Kernel Test Service https://01.org/lkp
