Re: [PATCH v5 3/5] scsi: core: Cap shost max_sectors according to DMA limits only once

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/07/2022 00:41, Damien Le Moal wrote:
shost->dma_dev = dma_dev; + if (dma_dev->dma_mask) {
+		shost->max_sectors = min_t(unsigned int, shost->max_sectors,
+				dma_max_mapping_size(dma_dev) >> SECTOR_SHIFT);
+	}
Nit: you could remove the curly brackets... But it being a multi-line
statement, having them is OK too I think.


tglx seems to think that they are ok, and I generally agree (now):

https://lore.kernel.org/linux-arm-kernel/877djwdorz.ffs@xxxxxxxxxxxxxxxxxxxxxxx/

AFAICT coding-style.rst is ok with them in this scenario too

Cheers,
John



[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux