On Wed, Jun 12, 2013 at 09:13:47AM +0200, Alessandro Rubini wrote: > +static void fmc_release(struct device *dev) > +{ > + struct fmc_device *fmc = container_of(dev, struct fmc_device, dev); > + > + kfree(fmc); > +} I read so many people who write new bus / device code that get this wrong, that I'm so overjoyed when it is written correctly, that I'm almost willing to just blindly accept this whole patchset. Almost :) Seriously, very nice job on the whole driver model integration for this code. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-doc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html