On Sat, May 14, 2022 at 12:28:04PM +0900, Robert Eckelmann wrote:
> Hello Johan,
>
> Below is a small patch regarding the io_ti driver.
> This patch enables the use of the Agilent E5805A USB-RS232(x4) adapter.
> It is a relabeled Inside Out Networks Edgeport with OEM USB-ID.
Thanks for the patch. Note that anything you write here in the body of
the will end up in the git commit message so greetings etc. should go
below the --- line.
> Signed-off-by: Robert Eckelmann <longnoserob@xxxxxxxxx>
> ---
> Documentation/usb/usb-serial.rst | 4 ++++
> drivers/usb/serial/io_ti.c | 2 ++
> drivers/usb/serial/io_usbvend.h | 2 +-
> 3 files changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/usb/usb-serial.rst b/Documentation/usb/usb-serial.rst
> index 69586aeb60bb..d9cfb6cb2d07 100644
> --- a/Documentation/usb/usb-serial.rst
> +++ b/Documentation/usb/usb-serial.rst
> @@ -412,6 +412,10 @@ Inside Out Networks Edgeport Driver
> - Edgeport/4 DIN
> - Edgeport/16 Dual
>
> + This dirver now also includes the Agilent E5805A usb-to-RS232 adapter device,
typo: dirver
> + as this is a rebranded Edgeport device.
But I don't we need to update the documentation here as the list isn't
complete as is.
Actually this entry appears to be for the io_edgeport driver.
> +
> +
> For any questions or problems with this driver, please contact Greg
> Kroah-Hartman at greg@xxxxxxxxx
>
> diff --git a/drivers/usb/serial/io_ti.c b/drivers/usb/serial/io_ti.c
> index a7b3c15957ba..2810cefa628d 100644
> --- a/drivers/usb/serial/io_ti.c
> +++ b/drivers/usb/serial/io_ti.c
> @@ -166,6 +166,7 @@ static const struct usb_device_id edgeport_2port_id_table[] = {
> { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_8S) },
> { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416) },
> { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416B) },
> + { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_E5805A)},
> { }
> };
>
> @@ -204,6 +205,7 @@ static const struct usb_device_id id_table_combined[] = {
> { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_8S) },
> { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416) },
> { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_TI_EDGEPORT_416B) },
> + { USB_DEVICE(USB_VENDOR_ID_ION, ION_DEVICE_ID_E5805A)},
> { }
> };
>
> diff --git a/drivers/usb/serial/io_usbvend.h b/drivers/usb/serial/io_usbvend.h
> index 52cbc353051f..3be6bce15d97 100644
> --- a/drivers/usb/serial/io_usbvend.h
> +++ b/drivers/usb/serial/io_usbvend.h
> @@ -212,7 +212,7 @@
> //
> // Definitions for other product IDs
> #define ION_DEVICE_ID_MT4X56USB 0x1403 // OEM device
> -
Please keep the double newline separator.
> +#define ION_DEVICE_ID_E5805A 0x1A01 // OEM device (internals based on Edgeport/4?)
Just say "rebranded" here too?
Could you please also post the output of usb-devices (or lsusb -v) for
this device for completeness?
>
> #define GENERATION_ID_FROM_USB_PRODUCT_ID(ProductId) \
> ((__u16) ((ProductId >> 8) & (ION_GENERATION_MASK)))
Johan
