Re: [PATCH v5 2/7] firmware: sysfb: Add helpers to unregister a pdev and disable registration

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi

Am 11.05.22 um 14:01 schrieb Javier Martinez Canillas:
Hello Thomas,

On 5/11/22 13:54, Thomas Zimmermann wrote:
Hi

Am 11.05.22 um 13:24 schrieb Javier Martinez Canillas:
These can be used by subsystems to unregister a platform device registered
by sysfb and also to disable future platform device registration in sysfb.


I find it very hard to review these patches, as related things are put
into separate patches.

I suggest to put the sysfb_disable() stuff into patch 5 and the rest
into patch 4.


Ok, you then want in the same patch to have both the helper definition
and first usage.

Other subsystems ask you to do the opposite, to split the definition and
usage in separate patches. But I'm fine with merging those if you prefer.

Usually, I have no strong opinion on this. But in the case of this specific patchset, I have the feeling that I'm missing some important point because call and implementation are separate. See my other replies for that. Putting them next to each other will hopefully help. Sorry for the inconvenience.

Best regards
Thomas

Best regards
Thomas



--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Maxfeldstr. 5, 90409 Nürnberg, Germany
(HRB 36809, AG Nürnberg)
Geschäftsführer: Ivo Totev

Attachment: OpenPGP_signature
Description: OpenPGP digital signature


[Index of Archives]     [Kernel Newbies]     [Security]     [Netfilter]     [Bugtraq]     [Linux FS]     [Yosemite Forum]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux