Re: [RFC PATCH v6 03/11] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

To: Ansuel Smith <ansuelsmth@xxxxxxxxx>
Subject: Re: [RFC PATCH v6 03/11] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode
From: Andrew Lunn <andrew@xxxxxxx>
Date: Thu, 5 May 2022 01:25:31 +0200
Cc: Vivien Didelot <vivien.didelot@xxxxxxxxx>, Florian Fainelli <f.fainelli@xxxxxxxxx>, Vladimir Oltean <olteanv@xxxxxxxxx>, "David S. Miller" <davem@xxxxxxxxxxxxx>, Jakub Kicinski <kuba@xxxxxxxxxx>, Paolo Abeni <pabeni@xxxxxxxxxx>, Rob Herring <robh+dt@xxxxxxxxxx>, Krzysztof Kozlowski <krzk+dt@xxxxxxxxxx>, Jonathan Corbet <corbet@xxxxxxx>, Pavel Machek <pavel@xxxxxx>, John Crispin <john@xxxxxxxxxxx>, netdev@xxxxxxxxxxxxxxx, devicetree@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-doc@xxxxxxxxxxxxxxx, linux-leds@xxxxxxxxxxxxxxx
In-reply-to: <20220503151633.18760-4-ansuelsmth@gmail.com>
References: <20220503151633.18760-1-ansuelsmth@gmail.com> <20220503151633.18760-4-ansuelsmth@gmail.com>

On Tue, May 03, 2022 at 05:16:25PM +0200, Ansuel Smith wrote:
> Drop NETDEV_LED_MODE_LINKUP from mode list and convert to a simple bool
> that will be true or false based on the carrier link. No functional
> change intended.

What is missing from the commit message is an explanation why?

     Andrew

Follow-Ups:
- Re: [RFC PATCH v6 03/11] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode
  - From: Ansuel Smith

References:
- [RFC PATCH v6 00/11] Adds support for PHY LEDs with offload triggers
  - From: Ansuel Smith
- [RFC PATCH v6 03/11] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode
  - From: Ansuel Smith

Prev by Date: Re: [RFC PATCH v6 02/11] leds: add function to configure hardware controlled LED
Next by Date: [PATCH 00/10] Encrypted Hibernation
Previous by thread: [RFC PATCH v6 03/11] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode
Next by thread: Re: [RFC PATCH v6 03/11] leds: trigger: netdev: drop NETDEV_LED_MODE_LINKUP from mode
Index(es):
- Date
- Thread

[Index of Archives] [Kernel Newbies] [Security] [Netfilter] [Bugtraq] [Linux FS] [Yosemite Forum] [MIPS Linux] [ARM Linux] [Linux Security] [Linux RAID] [Samba] [Video 4 Linux] [Device Mapper] [Linux Resources]