On Wed, May 04, 2022 at 10:34:39AM +0200, Javier Martinez Canillas wrote: > Hello Maxime, > > Thanks for your feedback. > > On 5/4/22 10:10, Maxime Ripard wrote: > > Hi, > > > > On Wed, May 04, 2022 at 10:02:12AM +0200, Javier Martinez Canillas wrote: > >> The Kernel Unit Testing (KUnit) framework provides a common framework for > >> unit tests within the Linux kernel. Having a test suite would allow to > >> identify regressions earlier. > >> > >> Signed-off-by: Javier Martinez Canillas <javierm@xxxxxxxxxx> > >> --- > >> > >> Documentation/gpu/todo.rst | 14 ++++++++++++++ > >> 1 file changed, 14 insertions(+) > >> > >> diff --git a/Documentation/gpu/todo.rst b/Documentation/gpu/todo.rst > >> index 127e76ee0b2d..10bfb50908d1 100644 > >> --- a/Documentation/gpu/todo.rst > >> +++ b/Documentation/gpu/todo.rst > >> @@ -603,6 +603,20 @@ Level: Advanced > >> Better Testing > >> ============== > >> > >> +Add unit tests using the Kernel Unit Testing (KUnit) framework > >> +-------------------------------------------------------------- > >> + > >> +The `KUnit <https://www.kernel.org/doc/html/latest/dev-tools/kunit/index.html>`_ > >> +provides a common framework for unit tests within the Linux kernel. Having a > >> +test suite would allow to identify regressions earlier. > >> + > >> +A good candidate for the first unit tests are the format-conversion helpers in > >> +``drm_format_helper.c``. > >> + > >> +Contact: Javier Martinez Canillas <javierm@xxxxxxxxxx> > >> + > >> +Level: Intermediate > > > > Kunit is fairly easy to grasp if you have some knowledge of other unit > > testing frameworks already (pytest, cmocka, etc.) > > > > Yes, I didn't set to intermediate due kunit but rather due the format > conversions, since the functions are not easy to read and understand. > > And the person writing the unit tests will have to get familiar with > the different formats to verify that conversions are done correctly. > > > Another good candidate would be to convert (some ?) selftests to kunit. > > I'm not sure the others, but at least test-drm_cmdline_parser should be > > fairly easy to convert. > > > > Indeed. Maybe I would add it as a separate entr though, as a follow-up. Yeah, that works for me Acked-by: Maxime Ripard <maxime@xxxxxxxxxx> Maxime
Attachment:
signature.asc
Description: PGP signature
