(I don't know why it looks like my previous reply has not been sent and it also disappeared from drafts. I apologize if for whatever reason you receive this message twice) On venerdì 22 aprile 2022 20:08:46 CEST Ira Weiny wrote: > On Thu, Apr 21, 2022 at 08:01:57PM +0200, Fabio M. De Francesco wrote: > > [snip] > > > diff --git a/include/linux/highmem.h b/include/linux/highmem.h > > index 39bb9b47fa9c..c3d562b5f0c1 100644 > > --- a/include/linux/highmem.h > > +++ b/include/linux/highmem.h > > @@ -37,7 +37,7 @@ static inline void *kmap(struct page *page); > > > > /** > > * kunmap - Unmap the virtual address mapped by kmap() > > - * @addr: Virtual address to be unmapped > > + * @page: Virtual address to be unmapped > ^^^^^^^^^^^^^^^ > Page > > Not only was the name wrong but the description of an address is wrong. Yes, correct. I'll rewrite this line the following way and send a v2 of this series while addressing also what it is required by your review of 3/4 (unless you have better suited suggestions): - * @addr: Virtual address to be unmapped + * @page: Pointer to the page which was mapped by kmap() > Other than that LGTM: > > Reviewed-by: Ira Weiny <ira.weiny@xxxxxxxxx> Thanks! Fabio
