Hello Pankaj, On 28.03.22 12:46, Pankaj Gupta wrote: > If the structure "struct keyblob_info", is used in patch 3/4, then below use for CAAM specific macros > will not be needed to be set in this file/function. Yes, I moved the output size computation into the previous patch. > If the structure "struct keyblob_info", is used in patch 3/4, then below line of code will not be needed. It must be set regardless. How else would the trusted key core know how big the blob is. > If the structure "struct keyblob_info", is used in patch 3/4, then below line of code will not be needed. > >> + p->key_len = length - CAAM_BLOB_OVERHEAD; Likewise. Cheers, Ahmad -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |